sim0n00ps/OF-DL
52
58
Fork 19
Code Issues 32 Pull Requests 1 Actions Packages Projects 1 Releases 15 Wiki Activity

Fix 32-bit integers #94

Merged
sim0n00ps merged 2 commits from whimsical-c4lic0/OF-DL:fix-32-bit-integers into master 2025-12-13 19:30:28 +00:00
Conversation 3 Commits 2 Files Changed 23 +175 -183
whimsical-c4lic0 commented 2025-12-13 09:01:31 +00:00
Collaborator
Copy Link

Address #92

  • Converts all ID's from integers to longs
  • Converts all sizes from integers to longs (not needed at this time but addresses what could be a problem in the future)
Address https://git.ofdl.tools/sim0n00ps/OF-DL/issues/92 - Converts all ID's from integers to longs - Converts all sizes from integers to longs (not needed at this time but addresses what could be a problem in the future)
whimsical-c4lic0 added 2 commits 2025-12-13 09:01:31 +00:00
ViRGEdx commented 2025-12-13 13:56:38 +00:00
First-time contributor
Copy Link

Just playing around with this, I had been concerned about it breaking the DB files, since the IDs are stored as integers there too. But it looks like SQLite's dynamic typing system can automatically handle the expansion from 32-bit to 64-bit integers, so everything looks good there.

Just playing around with this, I had been concerned about it breaking the DB files, since the IDs are stored as integers there too. But it looks like SQLite's dynamic typing system can automatically handle the expansion from 32-bit to 64-bit integers, so everything looks good there.
whimsical-c4lic0 commented 2025-12-13 17:25:08 +00:00
Author
Collaborator
Copy Link

Just playing around with this, I had been concerned about it breaking the DB files, since the IDs are stored as integers there too. But it looks like SQLite's dynamic typing system can automatically handle the expansion from 32-bit to 64-bit integers, so everything looks good there.

I had the same concern as well since I only have a basic knowledge of sqlite types, but yeah, all integer like types result in the same sqlite type regardless of the size. For anyone curious, the docs detail this in section 3.1.1 on this page: https://www.sqlite.org/datatype3.html

> Just playing around with this, I had been concerned about it breaking the DB files, since the IDs are stored as integers there too. But it looks like SQLite's dynamic typing system can automatically handle the expansion from 32-bit to 64-bit integers, so everything looks good there. I had the same concern as well since I only have a basic knowledge of sqlite types, but yeah, all integer like types result in the same sqlite type regardless of the size. For anyone curious, the docs detail this in section 3.1.1 on this page: https://www.sqlite.org/datatype3.html
melithine approved these changes 2025-12-13 19:12:19 +00:00
melithine left a comment
Collaborator
Copy Link

Works for me.

Works for me.
sim0n00ps merged commit 34f055b00e into master 2025-12-13 19:30:28 +00:00
whimsical-c4lic0 deleted branch fix-32-bit-integers 2025-12-13 20:33:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
melithine
Labels
Clear labels
bug
Something is not working
code-submitted
Some code has been written to address this issue, but has not yet made it into a release version yet.
duplicate
This issue or pull request already exists
feature-request
New feature
invalid
Something is wrong
needs-documentation
The OFDL documentation needs to be updated for this issue.
needs-info
More information is needed
triaged-and-escalated
This has been triaged and needs help from a specific developer.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
JIREX melithine whimsical-c4lic0 sim0n00ps
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sim0n00ps/OF-DL#94
No description provided.
Delete Branch "whimsical-c4lic0/OF-DL:fix-32-bit-integers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?