sim0n00ps/OF-DL
52
58
Fork 19
Code Issues 32 Pull Requests 1 Actions Packages Projects 1 Releases 15 Wiki Activity

Prevent partial DRM video downloads #142

Merged
sim0n00ps merged 3 commits from whimsical-c4lic0/OF-DL:fix-partial-video-downloads into master 2026-02-19 18:03:11 +00:00
Conversation 2 Commits 3 Files Changed 22 +748 -295
whimsical-c4lic0 commented 2026-02-13 07:05:44 +00:00
Collaborator
Copy Link

This PR adds ffprobe as a dependency to check the duration of DRM video downloads. It compares the downloaded video duration against the expected duration retrieved from the MPD manifest. A config value is used to set the allowed threshold (default 98%). If the duration ratio (actual / expected duration) is less than the threshold. The download will be deleted and tried again (up to 3 times). FFprobe is included in FFmpeg downloads, so no changes were needed in the docker image.

This PR adds ffprobe as a dependency to check the duration of DRM video downloads. It compares the downloaded video duration against the expected duration retrieved from the MPD manifest. A config value is used to set the allowed threshold (default 98%). If the duration ratio (actual / expected duration) is less than the threshold. The download will be deleted and tried again (up to 3 times). FFprobe is included in FFmpeg downloads, so no changes were needed in the docker image.
whimsical-c4lic0 added 2 commits 2026-02-13 07:05:45 +00:00
melithine commented 2026-02-17 15:26:38 +00:00
Collaborator
Copy Link

We'll need to update the installation docs about this, too, not just the new config options. It looks like we don't even mention the ffmpeg dependency on the Linux installation page currently, that's an oversight.

We'll need to update the installation docs about this, too, not just the new config options. It looks like we don't even mention the ffmpeg dependency on the Linux installation page currently, that's an oversight.
whimsical-c4lic0 commented 2026-02-17 17:56:41 +00:00
Author
Collaborator
Copy Link

The windows installation docs have been updated, but you're right about the Linux installation page. That will also need to be updated to reflect that the project uses .NET 10 instead of 8

The windows installation docs have been updated, but you're right about the Linux installation page. That will also need to be updated to reflect that the project uses .NET 10 instead of 8
👍 1
whimsical-c4lic0 added 1 commit 2026-02-17 18:38:00 +00:00
sim0n00ps merged commit 4b0bd4d676 into master 2026-02-19 18:03:11 +00:00
whimsical-c4lic0 deleted branch fix-partial-video-downloads 2026-02-19 18:15:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
code-submitted
Some code has been written to address this issue, but has not yet made it into a release version yet.
duplicate
This issue or pull request already exists
feature-request
New feature
invalid
Something is wrong
needs-documentation
The OFDL documentation needs to be updated for this issue.
needs-info
More information is needed
triaged-and-escalated
This has been triaged and needs help from a specific developer.
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
JIREX melithine whimsical-c4lic0 sim0n00ps
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sim0n00ps/OF-DL#142
No description provided.
Delete Branch "whimsical-c4lic0/OF-DL:fix-partial-video-downloads"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?